Fix typos (#10582)

HACKING.md

@@ -60,7 +60,7 @@ tabby
 |  ├─ src                               # Electron renderer code
 |  └─ main.js                           # Electron main entry point
 ├─ build
-├─ clink                                # Clink distributive, for Windows
+├─ clink                                # Clink distribution, for Windows
 ├─ scripts                              # Maintenance scripts
 ├─ tabby-community-color-schemes     # Plugin that provides color schemes
 ├─ tabby-core                        # Plugin that provides base UI and tab management

LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2017 Eugene Pankov
+Copyright (c) 2017 Tabby Developers
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

README.ko-KR.md

@@ -107,7 +107,7 @@ This README is also available in: <a  href="./README.md">:gb: English</a> · <a
 
 플러그인과 테마는 Tabby 내부의 설정에서 직접 설치할 수 있습니다.
 
-* [clickable-links](https://github.com/Eugeny/tabby-clickable-links) - m터미널의 경로 및 URL을 클릭 가능하게
+* [clickable-links](https://github.com/Eugeny/tabby-clickable-links) - 터미널의 경로 및 URL을 클릭 가능하게
 * [docker](https://github.com/Eugeny/tabby-docker) - Docker 컨테이너에 연결
 * [title-control](https://github.com/kbjr/terminus-title-control) - 접두사, 접미사 및/또는 문자열 제거를 제공하여 터미널 탭의 제목을 수정
 * [quick-cmds](https://github.com/Domain/terminus-quick-cmds) - 하나 또는 모든 터미널 탭에 신속한 명령 전송
@@ -144,7 +144,7 @@ Pull requests and plugins are welcome!
 ---
 <a name="contributors"></a>
 
-여기있는 멋진 사람들에게 진심으로 감사합니다. ([emoji key](https://allcontributors.org/docs/en/emoji-key)):
+여기 있는 멋진 사람들에게 진심으로 감사합니다. ([emoji key](https://allcontributors.org/docs/en/emoji-key)):
 
 <!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
 <!-- prettier-ignore-start -->

app/package.json

@@ -4,7 +4,7 @@
   "private": true,
   "repository": "https://github.com/Eugeny/tabby",
   "author": {
-    "name": "Eugene Pankov",
+    "name": "Tabby Developers",
     "email": "e@ajenti.org"
   },
   "main": "dist/main.js",

app/src/pluginBlacklist.ts

@@ -6,4 +6,6 @@ export const PLUGIN_BLACKLIST = [
     'terminus-clickable-ips', // broken, functionality now bundled with Tabby
     'terminus-elastic-quick-commands', // broken and abandoned, fork of quick-commands
     'terminus-elastic-quick-cmds', // broken and abandoned, fork of quick-commands
+    'tabby-fig', // abandoned,
+    'tabby-plugin-fig-integration', // abandoned,
 ]

scripts/vars.mjs

@@ -31,6 +31,7 @@ export const builtinPlugins = [
     'tabby-electron',
     'tabby-plugin-manager',
     'tabby-linkifier',
+    'tabby-auto-sudo-password',
 ]
 
 export const packagesWithDocs = [

tabby-auto-sudo-password/package.json

@@ -0,0 +1,23 @@
+{
+  "name": "tabby-auto-sudo-password",
+  "version": "1.0.197-nightly.1",
+  "description": "Offers to automatically paste saved sudo password in SSH sessions",
+  "keywords": [
+    "tabby-builtin-plugin"
+  ],
+  "main": "dist/index.js",
+  "typings": "typings/index.d.ts",
+  "scripts": {
+    "build": "webpack --progress --color --display-modules",
+    "watch": "webpack --progress --color --watch"
+  },
+  "files": [
+    "dist",
+    "typings"
+  ],
+  "devDependencies": {
+    "ansi-colors": "^4.1.1"
+  },
+  "author": "Tabby Developers",
+  "license": "MIT"
+}

tabby-auto-sudo-password/src/decorator.ts

@@ -0,0 +1,89 @@
+import colors from 'ansi-colors'
+import { Injectable } from '@angular/core'
+import { TerminalDecorator, BaseTerminalTabComponent, XTermFrontend, SessionMiddleware } from 'tabby-terminal'
+import { SSHProfile, SSHTabComponent, PasswordStorageService } from 'tabby-ssh'
+
+const SUDO_PROMPT_REGEX = /^\[sudo\] password for ([^:]+):\s*$/im
+
+export class AutoSudoPasswordMiddleware extends SessionMiddleware {
+    private pendingPasswordToPaste: string | null = null
+    private pasteHint = `${colors.black.bgBlackBright(' Tabby ')} ${colors.gray('Press Enter to paste saved password')}`
+    private pasteHintLength = colors.stripColor(this.pasteHint).length
+
+    constructor (
+        private profile: SSHProfile,
+        private ps: PasswordStorageService,
+    ) { super() }
+
+    feedFromSession (data: Buffer): void {
+        const text = data.toString('utf-8')
+        const match = SUDO_PROMPT_REGEX.exec(text)
+        if (match) {
+            const username = match[1]
+            this.handlePrompt(username)
+        }
+        this.outputToTerminal.next(data)
+    }
+
+    feedFromTerminal (data: Buffer): void {
+        if (this.pendingPasswordToPaste) {
+            const backspaces = Buffer.alloc(this.pasteHintLength, 8) // backspace
+            const spaces = Buffer.alloc(this.pasteHintLength, 32) // space
+            const clear = Buffer.concat([backspaces, spaces, backspaces])
+            this.outputToTerminal.next(clear)
+            if (data.length === 1 && data[0] === 13) { // Enter key
+                this.outputToSession.next(Buffer.from(this.pendingPasswordToPaste + '\n'))
+                this.pendingPasswordToPaste = null
+                return
+            } else {
+                this.pendingPasswordToPaste = null
+            }
+        }
+        this.outputToSession.next(data)
+    }
+
+    async handlePrompt (username: string): Promise<void> {
+        console.log(`Detected sudo prompt for user: ${username}`)
+        const pw = await this.ps.loadPassword(this.profile)
+        if (pw) {
+            this.outputToTerminal.next(Buffer.from(this.pasteHint))
+            this.pendingPasswordToPaste = pw
+        }
+    }
+
+    async loadPassword (username: string): Promise<string| null> {
+        if (this.profile.options.user !== username) {
+            return null
+        }
+        return this.ps.loadPassword(this.profile)
+    }
+}
+
+@Injectable()
+export class AutoSudoPasswordDecorator extends TerminalDecorator {
+    constructor (
+        private ps: PasswordStorageService,
+    ) {
+        super()
+    }
+
+    private attachToSession (tab: SSHTabComponent) {
+        if (!tab.session) {
+            return
+        }
+        tab.session.middleware.unshift(new AutoSudoPasswordMiddleware(tab.profile, this.ps))
+    }
+
+    attach (tab: BaseTerminalTabComponent<any>): void {
+        if (!(tab.frontend instanceof XTermFrontend) || !(tab instanceof SSHTabComponent)) {
+            return
+        }
+
+        setTimeout(() => {
+            this.attachToSession(tab)
+            this.subscribeUntilDetached(tab, tab.sessionChanged$.subscribe(() => {
+                this.attachToSession(tab)
+            }))
+        })
+    }
+}

tabby-auto-sudo-password/src/index.ts

@@ -0,0 +1,16 @@
+/* eslint-disable @typescript-eslint/no-extraneous-class */
+import { NgModule } from '@angular/core'
+import { ToastrModule } from 'ngx-toastr'
+import { TerminalDecorator } from 'tabby-terminal'
+
+import { AutoSudoPasswordDecorator } from './decorator'
+
+@NgModule({
+    imports: [
+        ToastrModule,
+    ],
+    providers: [
+        { provide: TerminalDecorator, useClass: AutoSudoPasswordDecorator, multi: true },
+    ],
+})
+export default class AutoSudoPasswordModule { }

tabby-auto-sudo-password/tsconfig.json

@@ -0,0 +1,7 @@
+{
+  "extends": "../tsconfig.json",
+  "exclude": ["node_modules", "dist"],
+  "compilerOptions": {
+    "baseUrl": "src",
+  }
+}

tabby-auto-sudo-password/tsconfig.typings.json

@@ -0,0 +1,14 @@
+{
+  "extends": "../tsconfig.json",
+  "exclude": ["node_modules", "dist", "typings"],
+  "compilerOptions": {
+    "baseUrl": "src",
+    "emitDeclarationOnly": true,
+    "declaration": true,
+    "declarationDir": "./typings",
+    "paths": {
+      "tabby-*": ["../../tabby-*"],
+      "*": ["../../app/node_modules/*"]
+    }
+  }
+}

tabby-auto-sudo-password/webpack.config.mjs

@@ -0,0 +1,10 @@
+import * as path from 'path'
+import * as url from 'url'
+const __dirname = url.fileURLToPath(new URL('.', import.meta.url))
+
+import config from '../webpack.plugin.config.mjs'
+
+export default () => config({
+    name: 'auto-sudo-password',
+    dirname: __dirname,
+})

tabby-auto-sudo-password/yarn.lock

@@ -0,0 +1,8 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+
+ansi-colors@^4.1.1:
+  version "4.1.3"
+  resolved "https://registry.yarnpkg.com/ansi-colors/-/ansi-colors-4.1.3.tgz#37611340eb2243e70cc604cad35d63270d48781b"
+  integrity sha512-/6w/C21Pm1A7aZitlI5Ni/2J6FFQN8i1Cvz3kHABAAbw93v/NlvKdVOqz7CCWz/3iv/JplRSEEZ83XION15ovw==

tabby-community-color-schemes/package.json

@@ -14,7 +14,7 @@
   "files": [
     "dist"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "peerDependencies": {
     "@angular/core": "^15",

tabby-core/package.json

@@ -15,7 +15,7 @@
     "dist",
     "typings"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "devDependencies": {
     "bootstrap": "^5.3.0-alpha.1",

tabby-core/src/components/appRoot.component.pug

@@ -35,7 +35,8 @@ title-bar(
                 [@animateTab]='{value: "in", params: {size: targetTabSize}}',
                 [@.disabled]='hasVerticalTabs() || !config.store.accessibility.animations',
                 (click)='app.selectTab(tab)',
-                [class.fully-draggable]='hostApp.platform !== Platform.macOS'
+                [class.fully-draggable]='hostApp.platform !== Platform.macOS',
+                [ngbTooltip]='tab.customTitle || tab.title'
             )
 
         .btn-group.background
@@ -43,7 +44,7 @@ title-bar(
                 *ngFor='let button of leftToolbarButtons'
             )
                 button.btn.btn-secondary.btn-tab-bar(
-                    [title]='button.label',
+                    [ngbTooltip]='button.label',
                     (click)='button.run && button.run()',
                     [fastHtmlBind]='button.icon'
                 )
@@ -55,7 +56,7 @@ title-bar(
             )
                 button.btn.btn-secondary.btn-tab-bar(
                     [hidden]='activeTransfers.length == 0',
-                    title='File transfers',
+                    [ngbTooltip]='"File transfers"|translate',
                     ngbDropdownToggle
                 ) !{require('../icons/transfers.svg')}
                 transfers-menu(
@@ -75,14 +76,14 @@ title-bar(
                 *ngFor='let button of rightToolbarButtons'
             )
                 button.btn.btn-secondary.btn-tab-bar(
-                    [title]='button.label',
+                    [ngbTooltip]='button.label',
                     (click)='button.run && button.run()',
                     [fastHtmlBind]='button.icon'
                 )
 
             button.btn.btn-secondary.btn-tab-bar.btn-update(
                 *ngIf='updatesAvailable',
-                title='Update available - Click to install',
+                [ngbTooltip]='"Update available - Click to install"|translate',
                 (click)='updater.update()'
             ) !{require('../icons/gift.svg')}
 

tabby-core/src/components/tabHeader.component.pug

@@ -13,7 +13,6 @@ profile-icon(
 )
 
 .name(
-    [title]='tab.customTitle || tab.title',
     [class.no-hover]='config.store.terminal.hideCloseButton && config.store.terminal.hideTabOptionsButton'
     cdkDrag,
     cdkDragRootElement='tab-header',

tabby-core/src/components/transfersMenu.component.pug

@@ -5,7 +5,7 @@
     .icon(*ngIf='isDownload(transfer)') !{require('../icons/download.svg')}
     .icon(*ngIf='!isDownload(transfer)') !{require('../icons/upload.svg')}
     .main
-        label.no-wrap([title]='transfer.getName()') {{transfer.getName()}}
+        label.no-wrap([ngbTooltip]='transfer.getName()') {{transfer.getName()}}
         ngb-progressbar([type]='transfer.isComplete() ? "success" : transfer.isCancelled() ? "danger" : "info"', [value]='getProgress(transfer)')
         .metadata
             .size {{transfer.getSize()|filesize}}

tabby-core/src/index.ts

@@ -2,7 +2,7 @@ import { NgModule, ModuleWithProviders, LOCALE_ID } from '@angular/core'
 import { BrowserAnimationsModule } from '@angular/platform-browser/animations'
 import { CommonModule } from '@angular/common'
 import { FormsModule } from '@angular/forms'
-import { NgbModule } from '@ng-bootstrap/ng-bootstrap'
+import { NgbModule, NgbTooltipConfig } from '@ng-bootstrap/ng-bootstrap'
 import { NgxFilesizeModule } from 'ngx-filesize'
 import { DragDropModule } from '@angular/cdk/drag-drop'
 import { TranslateModule, TranslateCompiler, TranslateService, MissingTranslationHandler } from '@ngx-translate/core'
@@ -155,6 +155,7 @@ export default class AppModule { // eslint-disable-line @typescript-eslint/no-ex
         platform: PlatformService,
         hotkeys: HotkeysService,
         commands: CommandService,
+        ngbTooltipConfig: NgbTooltipConfig,
         public locale: LocaleService,
         private translate: TranslateService,
         private profilesService: ProfilesService,
@@ -201,6 +202,10 @@ export default class AppModule { // eslint-disable-line @typescript-eslint/no-ex
                 commands.run('core:profile-selector', {})
             }
         })
+
+        ngbTooltipConfig.openDelay = 750
+        ngbTooltipConfig.placement = 'top bottom auto'
+        ngbTooltipConfig.container = 'body'
     }
 
     async showSelector (provider: ProfileProvider<Profile>): Promise<void> {

tabby-electron/package.json

@@ -15,7 +15,7 @@
     "dist",
     "typings"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "peerDependencies": {
     "@angular/core": "^15",

tabby-linkifier/package.json

@@ -15,7 +15,7 @@
     "dist",
     "typings"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "devDependencies": {
     "@xterm/addon-web-links": "^0.10.0",

tabby-local/package.json

@@ -15,7 +15,7 @@
     "dist",
     "typings"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "devDependencies": {
     "ansi-colors": "^4.1.1",

tabby-plugin-manager/package.json

@@ -15,7 +15,7 @@
     "dist",
     "typings"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "devDependencies": {
     "@types/semver": "^7.1.0",

tabby-plugin-manager/src/components/pluginsSettingsTab.component.ts

@@ -100,6 +100,7 @@ export class PluginsSettingsTabComponent {
             this.busy.delete(plugin.name)
             this.config.requestRestart()
         } catch (err) {
+            console.error('Error installing plugin', plugin.name, err)
             this.erroredPlugin = plugin.name
             this.errorMessage = err
             this.busy.delete(plugin.name)
@@ -114,6 +115,7 @@ export class PluginsSettingsTabComponent {
             this.busy.delete(plugin.name)
             this.config.requestRestart()
         } catch (err) {
+            console.error('Error uninstalling plugin', plugin.name, err)
             this.erroredPlugin = plugin.name
             this.errorMessage = err
             this.busy.delete(plugin.name)

tabby-serial/package.json

@@ -15,7 +15,7 @@
     "dist",
     "typings"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "devDependencies": {
     "@types/node": "14.14.14",

tabby-settings/package.json

@@ -15,7 +15,7 @@
     "dist",
     "typings"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "devDependencies": {
     "@types/marked": "^5.0.1",

tabby-ssh/package.json

@@ -17,7 +17,7 @@
     "dist",
     "typings"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "devDependencies": {
     "@types/node": "20.3.1",

tabby-ssh/src/components/sshTab.component.ts

@@ -179,6 +179,7 @@ export class SSHTabComponent extends ConnectableTerminalTabComponent<SSHProfile>
             try {
                 await this.initializeSessionMaybeMultiplex(false)
             } catch (e) {
+                console.error('SSH session initialization failed', e)
                 this.write(colors.black.bgRed(' X ') + ' ' + colors.red(e.message) + '\r\n')
                 return
             }

tabby-ssh/src/index.ts

@@ -66,4 +66,5 @@ export default class SSHModule { }
 
 export * from './api'
 export { SFTPFile, SFTPSession } from './session/sftp'
-export { SFTPPanelComponent }
+export { SFTPPanelComponent, SSHTabComponent }
+export { PasswordStorageService } from './services/passwordStorage.service'

tabby-telnet/package.json

@@ -15,7 +15,7 @@
     "dist",
     "typings"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "devDependencies": {
     "ansi-colors": "^4.1.1",

tabby-terminal/package.json

@@ -16,7 +16,7 @@
     "dist",
     "typings"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "devDependencies": {
     "@xterm/addon-canvas": "^0.6.0",

tabby-terminal/src/api/baseTerminalTab.component.ts

@@ -17,6 +17,8 @@ import { getTerminalBackgroundColor } from '../helpers'
 
 
 const INACTIVE_TAB_UNLOAD_DELAY = 1000 * 30
+const OSC_FOCUS_IN = Buffer.from('\x1b[I')
+const OSC_FOCUS_OUT = Buffer.from('\x1b[O')
 
 /**
  * A class to base your custom terminal tabs on
@@ -494,7 +496,7 @@ export class BaseTerminalTabComponent<P extends BaseTerminalProfile> extends Bas
             data = Buffer.from(data, 'utf-8')
         }
         this.session?.feedFromTerminal(data)
-        if (this.config.store.terminal.scrollOnInput) {
+        if (this.config.store.terminal.scrollOnInput && !data.equals(OSC_FOCUS_IN) && !data.equals(OSC_FOCUS_OUT)) {
             this.frontend?.scrollToBottom()
         }
     }
@@ -542,7 +544,7 @@ export class BaseTerminalTabComponent<P extends BaseTerminalProfile> extends Bas
         }
 
         if (!this.alternateScreenActive) {
-            if (data.includes('\r') && this.config.store.terminal.warnOnMultilinePaste) {
+            if ((data.includes('\r') || data.includes('\n')) && this.config.store.terminal.warnOnMultilinePaste) {
                 const buttons = [
                     this.translate.instant('Paste'),
                     this.translate.instant('Cancel'),

tabby-terminal/src/components/searchPanel.component.pug

@@ -16,14 +16,14 @@
 ng-container(*ngIf='state.resultCount > 0')
     button.btn.btn-link(
         (click)='findPrevious()',
-        ngbTooltip='Search up',
+        [ngbTooltip]='"Search up"|translate',
         placement='bottom',
         [fastHtmlBind]='icons.arrowUp'
     )
 
     button.btn.btn-link(
         (click)='findNext()',
-        ngbTooltip='Search down',
+        [ngbTooltip]='"Search down"|translate',
         placement='bottom',
         [fastHtmlBind]='icons.arrowDown'
     )
@@ -34,7 +34,7 @@ button.btn(
     (click)='options.caseSensitive = !options.caseSensitive; saveSearchOptions()',
     [class.btn-link]='!options.caseSensitive',
     [class.btn-info]='options.caseSensitive',
-    ngbTooltip='Case sensitivity',
+    [ngbTooltip]='"Case sensitivity"|translate',
     placement='bottom',
     [fastHtmlBind]='icons.case'
 )
@@ -43,7 +43,7 @@ button.btn(
     (click)='options.regex = !options.regex; saveSearchOptions()',
     [class.btn-link]='!options.regex',
     [class.btn-info]='options.regex',
-    ngbTooltip='Regular expression',
+    [ngbTooltip]='"Regular expression"|translate',
     placement='bottom',
     [fastHtmlBind]='icons.regexp'
 )
@@ -52,7 +52,7 @@ button.btn(
     (click)='options.wholeWord = !options.wholeWord; saveSearchOptions()',
     [class.btn-link]='!options.wholeWord',
     [class.btn-info]='options.wholeWord',
-    ngbTooltip='Whole word',
+    [ngbTooltip]='"Whole word"|translate',
     placement='bottom',
     [fastHtmlBind]='icons.wholeWord'
 )

tabby-web-demo/package.json

@@ -11,7 +11,7 @@
     "data",
     "dist"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "devDependencies": {
     "@types/webpack-env": "^1.16.0"

tabby-web/package.json

@@ -15,7 +15,7 @@
     "dist",
     "typings"
   ],
-  "author": "Eugene Pankov",
+  "author": "Tabby Developers",
   "license": "MIT",
   "peerDependencies": {
     "@angular/core": "^15"