GuanM/tabby
1
0
Fork 0
mirror of https://github.com/Eugeny/tabby.git synced 2025-06-19 10:59:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix tab showing activity indicator even without new data

Browse Source 
Fix regression from 7be921592a355334af45965d166fb08dfdcee942

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
This commit is contained in:
Matheus Castello 2022-06-29 22:09:54 -03:00 committed by Eugene
parent c75294e03a
commit 1afdb4a398
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tabby-core/src/services/app.service.ts
View File

@ -139,12 +139,6 @@ export class AppService {
this.tabClosed.next(tab) this.tabClosed.next(tab)
}) })
tab.activity$.subscribe(() => {
if (tab === this._activeTab) {
tab.clearActivity()
}
})
if (tab instanceof SplitTabComponent) { if (tab instanceof SplitTabComponent) {
tab.tabAdded$.subscribe(() => this.emitTabsChanged()) tab.tabAdded$.subscribe(() => this.emitTabsChanged())
tab.tabRemoved$.subscribe(() => this.emitTabsChanged()) tab.tabRemoved$.subscribe(() => this.emitTabsChanged())

2
tabby-core/src/tabContextMenu.ts
View File

@ -201,6 +201,8 @@ export class TaskCompletionContextMenu extends TabContextMenuItemProvider {
type: 'checkbox', type: 'checkbox',
checked: !!extTab.__outputNotificationSubscription, checked: !!extTab.__outputNotificationSubscription,
click: () => { click: () => {
tab.clearActivity()
if (extTab.__outputNotificationSubscription) { if (extTab.__outputNotificationSubscription) {
extTab.__outputNotificationSubscription.unsubscribe() extTab.__outputNotificationSubscription.unsubscribe()
extTab.__outputNotificationSubscription = null extTab.__outputNotificationSubscription = null