From 1afdb4a39837d2c7337f9027586f29ffed9e6eaa Mon Sep 17 00:00:00 2001 From: Matheus Castello Date: Wed, 29 Jun 2022 22:09:54 -0300 Subject: [PATCH] Fix tab showing activity indicator even without new data Fix regression from 7be921592a355334af45965d166fb08dfdcee942 Signed-off-by: Matheus Castello --- tabby-core/src/services/app.service.ts | 6 ------ tabby-core/src/tabContextMenu.ts | 2 ++ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tabby-core/src/services/app.service.ts b/tabby-core/src/services/app.service.ts index 98071aea..324e8574 100644 --- a/tabby-core/src/services/app.service.ts +++ b/tabby-core/src/services/app.service.ts @@ -139,12 +139,6 @@ export class AppService { this.tabClosed.next(tab) }) - tab.activity$.subscribe(() => { - if (tab === this._activeTab) { - tab.clearActivity() - } - }) - if (tab instanceof SplitTabComponent) { tab.tabAdded$.subscribe(() => this.emitTabsChanged()) tab.tabRemoved$.subscribe(() => this.emitTabsChanged()) diff --git a/tabby-core/src/tabContextMenu.ts b/tabby-core/src/tabContextMenu.ts index b40cb28d..d45b65e0 100644 --- a/tabby-core/src/tabContextMenu.ts +++ b/tabby-core/src/tabContextMenu.ts @@ -201,6 +201,8 @@ export class TaskCompletionContextMenu extends TabContextMenuItemProvider { type: 'checkbox', checked: !!extTab.__outputNotificationSubscription, click: () => { + tab.clearActivity() + if (extTab.__outputNotificationSubscription) { extTab.__outputNotificationSubscription.unsubscribe() extTab.__outputNotificationSubscription = null