fixed #8093 - SFTP panel visual issues

tabby-core/src/components/baseTab.component.ts

@@ -192,6 +192,14 @@ export abstract class BaseTabComponent extends BaseComponent {
         this.viewContainer = undefined
     }
 
+    get topmostParent (): BaseTabComponent|null {
+        let parent = this.parent
+        while (parent?.parent) {
+            parent = parent.parent
+        }
+        return parent
+    }
+
     /**
      * Called before the tab is closed
      */

tabby-core/src/components/splitTab.component.ts

@@ -458,12 +458,18 @@ export class SplitTabComponent extends BaseTabComponent implements AfterViewInit
             tab.destroy()
         }
 
+        let allTabs: BaseTabComponent[] = []
         if (thing instanceof BaseTabComponent) {
-            if (thing.parent instanceof SplitTabComponent) {
+            allTabs = [thing]
-                thing.parent.removeTab(thing)
+        } else if (thing instanceof SplitContainer) {
+            allTabs = thing.getAllTabs()
+        }
+        for (const tab of allTabs) {
+            if (tab.parent instanceof SplitTabComponent) {
+                tab.parent.removeTab(tab)
             }
-            thing.removeFromContainer()
+            tab.removeFromContainer()
-            thing.parent = this
+            tab.parent = this
         }
 
         let target = relative ? this.getParentOf(relative) : null

tabby-ssh/src/components/sftpPanel.component.scss

@@ -46,6 +46,6 @@
     }
 }
 
-.btn-close svg {
+.btn-link svg {
     width: 12px;
 }

tabby-terminal/src/components/terminalToolbar.component.scss

@@ -2,6 +2,7 @@
     padding: 5px 15px 5px 15px;
     display: flex;
     z-index: 3;
+    overflow: hidden;
 
     ::ng-deep .btn {
         white-space: nowrap;

tabby-terminal/src/components/terminalToolbar.component.ts

@@ -29,7 +29,7 @@ export class TerminalToolbarComponent {
     }
 
     get shouldShowDragHandle (): boolean {
-        return this.tab.parent instanceof SplitTabComponent && this.tab.parent.getAllTabs().length > 1
+        return this.tab.topmostParent instanceof SplitTabComponent && this.tab.topmostParent.getAllTabs().length > 1
     }
 
     @HostListener('mouseenter') onMouseEnter () {