From eaf4ed9855f45e7da87646eef0e72f621f636fdf Mon Sep 17 00:00:00 2001 From: Eugene Pankov Date: Fri, 15 Apr 2022 18:55:00 +0200 Subject: [PATCH] expose the drawBoldTextInBrightColors option - fixes #3149 --- .../src/components/terminalSettingsTab.component.pug | 8 ++++++++ tabby-terminal/src/config.ts | 1 + tabby-terminal/src/frontends/xtermFrontend.ts | 3 +++ 3 files changed, 12 insertions(+) diff --git a/tabby-terminal/src/components/terminalSettingsTab.component.pug b/tabby-terminal/src/components/terminalSettingsTab.component.pug index 365f4ce9..618be264 100644 --- a/tabby-terminal/src/components/terminalSettingsTab.component.pug +++ b/tabby-terminal/src/components/terminalSettingsTab.component.pug @@ -23,6 +23,14 @@ div (ngModelChange)='config.save()', ) + .form-line + .header + .title(translate) Draw bold text in bright colors + toggle( + [(ngModel)]='config.store.terminal.drawBoldTextInBrightColors', + (ngModelChange)='config.save()' + ) + div.mt-4 h3(translate) Keyboard diff --git a/tabby-terminal/src/config.ts b/tabby-terminal/src/config.ts index 8a7852b6..05507d8a 100644 --- a/tabby-terminal/src/config.ts +++ b/tabby-terminal/src/config.ts @@ -67,6 +67,7 @@ export class TerminalConfigProvider extends ConfigProvider { }, detectProgress: true, scrollbackLines: 25000, + drawBoldTextInBrightColors: true, }, } diff --git a/tabby-terminal/src/frontends/xtermFrontend.ts b/tabby-terminal/src/frontends/xtermFrontend.ts index 9eb08004..9e0eb833 100644 --- a/tabby-terminal/src/frontends/xtermFrontend.ts +++ b/tabby-terminal/src/frontends/xtermFrontend.ts @@ -292,6 +292,9 @@ export class XTermFrontend extends Frontend { this.xterm.options.macOptionIsMeta = config.terminal.altIsMeta this.xterm.options.scrollback = config.terminal.scrollbackLines this.xterm.options.wordSeparator = config.terminal.wordSeparator + this.xterm.options.drawBoldTextInBrightColors = config.terminal.drawBoldTextInBrightColors + this.xterm.options.fontWeight = config.terminal.fontWeight + this.xterm.options.fontWeightBold = config.terminal.fontWeightBold this.configuredFontSize = config.terminal.fontSize this.configuredLinePadding = config.terminal.linePadding this.setFontSize()