ssh reconnection logic improvements - fixes #2705, fixes #761, fixes #2662

terminus-terminal/src/api/baseTerminalTab.component.ts

@@ -474,7 +474,7 @@ export class BaseTerminalTabComponent extends BaseTabComponent implements OnInit
         ]
     }
 
-    protected attachSessionHandlers (): void {
+    protected attachSessionHandlers (destroyOnSessionClose = false): void {
         // this.session.output$.bufferTime(10).subscribe((datas) => {
         this.session.output$.subscribe(data => {
             if (this.enablePassthrough) {
@@ -485,9 +485,11 @@ export class BaseTerminalTabComponent extends BaseTabComponent implements OnInit
             }
         })
 
-        this.sessionCloseSubscription = this.session.closed$.subscribe(() => {
-            this.frontend.destroy()
-            this.destroy()
-        })
+        if (destroyOnSessionClose) {
+            this.sessionCloseSubscription = this.session.closed$.subscribe(() => {
+                this.frontend.destroy()
+                this.destroy()
+            })
+        }
     }
 }

terminus-terminal/src/components/terminalTab.component.ts

@@ -60,7 +60,7 @@ export class TerminalTabComponent extends BaseTerminalTabComponent {
             })
         )
 
-        this.attachSessionHandlers()
+        this.attachSessionHandlers(true)
     }
 
     async getRecoveryToken (): Promise<any> {

terminus-terminal/src/services/sessions.service.ts

@@ -73,6 +73,8 @@ export abstract class BaseSession {
             this.open = false
             this.closed.next()
             this.destroyed.next()
+            this.closed.complete()
+            this.destroyed.complete()
             this.output.complete()
             this.binaryOutput.complete()
             await this.gracefullyKillProcess()