GuanM/tabby
1
0
Fork 0
mirror of https://github.com/Eugeny/tabby.git synced 2025-09-24 09:06:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

disallow disabling core plugins - fixes #1990

Browse Source
This commit is contained in:
Eugene Pankov
2021-03-13 21:25:25 +01:00
parent c290633e7e
commit be43f8b50d
4 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
terminus-core/src/components/checkbox.component.ts
View File

@@ -17,7 +17,7 @@ import { ControlValueAccessor, NG_VALUE_ACCESSOR } from '@angular/forms'
}) })
export class CheckboxComponent implements ControlValueAccessor { export class CheckboxComponent implements ControlValueAccessor {
@HostBinding('class.active') @Input() model: boolean @HostBinding('class.active') @Input() model: boolean
@Input() disabled: boolean @HostBinding('class.disabled') @Input() disabled: boolean
@Input() text: string @Input() text: string
private changed = new Array<(val: boolean) => void>() private changed = new Array<(val: boolean) => void>()

6
terminus-core/src/components/toggle.component.scss
View File

@@ -3,7 +3,6 @@
$toggle-size: 18px; $toggle-size: 18px;
$height: 30px; $height: 30px;
$padding: 2px; $padding: 2px;
cursor: pointer;
display: inline-flex; display: inline-flex;
overflow: visible; overflow: visible;
border-radius: 3px; border-radius: 3px;
@@ -16,8 +15,11 @@
padding-left: 10px; padding-left: 10px;
margin-left: -10px; margin-left: -10px;
&[disabled] { &.disabled {
opacity: 0.5; opacity: 0.5;
} }
* {
cursor: pointer;
}
} }

3
terminus-plugin-manager/src/components/pluginsSettingsTab.component.pug
View File

@@ -12,7 +12,8 @@
.list-group-item.d-flex.align-items-center(*ngFor='let plugin of pluginManager.installedPlugins') .list-group-item.d-flex.align-items-center(*ngFor='let plugin of pluginManager.installedPlugins')
toggle( toggle(
[ngModel]='isPluginEnabled(plugin)', [ngModel]='isPluginEnabled(plugin)',
(ngModelChange)='togglePlugin(plugin)' (ngModelChange)='togglePlugin(plugin)',
[disabled]='!canDisablePlugin(plugin)'
) )
.mr-auto.d-flex.flex-column .mr-auto.d-flex.flex-column

6
terminus-plugin-manager/src/components/pluginsSettingsTab.component.ts
View File

@@ -9,6 +9,8 @@ import { PluginInfo, PluginManagerService } from '../services/pluginManager.serv
enum BusyState { Installing = 'Installing', Uninstalling = 'Uninstalling' } enum BusyState { Installing = 'Installing', Uninstalling = 'Uninstalling' }
const FORCE_ENABLE = ['terminus-core', 'terminus-settings']
/** @hidden */ /** @hidden */
@Component({ @Component({
template: require('./pluginsSettingsTab.component.pug'), template: require('./pluginsSettingsTab.component.pug'),
@@ -106,6 +108,10 @@ export class PluginsSettingsTabComponent {
return !this.config.store.pluginBlacklist.includes(plugin.name) return !this.config.store.pluginBlacklist.includes(plugin.name)
} }
canDisablePlugin (plugin: PluginInfo) {
return !FORCE_ENABLE.includes(plugin.packageName)
}
togglePlugin (plugin: PluginInfo) { togglePlugin (plugin: PluginInfo) {
if (this.isPluginEnabled(plugin)) { if (this.isPluginEnabled(plugin)) {
this.disablePlugin(plugin) this.disablePlugin(plugin)