lint

.eslintrc.yml

@@ -111,7 +111,6 @@ rules:
   '@typescript-eslint/lines-between-class-members':
   - error
   - exceptAfterSingleLine: true
-  '@typescript-eslint/non-nullable-type-assertion-style': off
   '@typescript-eslint/dot-notation': off
   '@typescript-eslint/no-confusing-void-expression': off
   '@typescript-eslint/no-implicit-any-catch': off

app/src/plugins.ts

@@ -173,8 +173,8 @@ export async function loadPlugins (foundPlugins: PluginInfo[], progress: Progres
             console.time(label)
             const packageModule = nodeRequire(foundPlugin.path)
             const pluginModule = packageModule.default.forRoot ? packageModule.default.forRoot() : packageModule.default
-            pluginModule['pluginName'] = foundPlugin.name
+            pluginModule.pluginName = foundPlugin.name
-            pluginModule['bootstrap'] = packageModule.bootstrap
+            pluginModule.bootstrap = packageModule.bootstrap
             plugins.push(pluginModule)
             console.timeEnd(label)
             await new Promise(x => setTimeout(x, 50))

terminus-core/src/services/config.service.ts

@@ -194,10 +194,10 @@ export class ConfigService {
             this.servicesCache = {}
             const ngModule = window['rootModule'].ɵinj
             for (const imp of ngModule.imports) {
-                const module = imp['ngModule'] || imp
+                const module = imp.ngModule || imp
                 if (module.ɵinj?.providers) {
-                    this.servicesCache[module['pluginName']] = module.ɵinj.providers.map(provider => {
+                    this.servicesCache[module.pluginName] = module.ɵinj.providers.map(provider => {
-                        return provider['useClass'] || provider
+                        return provider.useClass || provider
                     })
                 }
             }

terminus-core/src/services/shellIntegration.service.ts

@@ -44,7 +44,7 @@ export class ShellIntegrationService {
                 'extras',
                 'automator-workflows',
             )
-            this.automatorWorkflowsDestination = path.join(process.env.HOME as string, 'Library', 'Services')
+            this.automatorWorkflowsDestination = path.join(process.env.HOME!, 'Library', 'Services')
         }
         this.updatePaths()
     }

terminus-serial/src/recoveryProvider.ts

@@ -11,8 +11,8 @@ export class RecoveryProvider extends TabRecoveryProvider {
             return {
                 type: SerialTabComponent,
                 options: {
-                    connection: recoveryToken['connection'],
+                    connection: recoveryToken.connection,
-                    savedState: recoveryToken['savedState'],
+                    savedState: recoveryToken.savedState,
                 },
             }
         }

terminus-settings/src/components/settingsTab.component.ts

@@ -143,7 +143,7 @@ export class SettingsTabComponent extends BaseTabComponent {
 
     hotkeyFilterFn (hotkey: HotkeyDescription, query: string): boolean {
         // eslint-disable-next-line @typescript-eslint/restrict-plus-operands
-        const s = hotkey.name + (this.getHotkey(hotkey.id) || []).toString() as string
+        const s = hotkey.name + (this.getHotkey(hotkey.id) || []).toString()
         return s.toLowerCase().includes(query.toLowerCase())
     }
 }

terminus-ssh/src/services/ssh.service.ts

@@ -57,7 +57,7 @@ export class SSHService {
         let privateKeyPath = session.connection.privateKey
 
         if (!privateKeyPath) {
-            const userKeyPath = path.join(process.env.HOME as string, '.ssh', 'id_rsa')
+            const userKeyPath = path.join(process.env.HOME!, '.ssh', 'id_rsa')
             if (await fs.exists(userKeyPath)) {
                 logCallback?.('Using user\'s default private key')
                 privateKeyPath = userKeyPath
@@ -219,7 +219,7 @@ export class SSHService {
                     }
                 }
             } else {
-                agent = process.env.SSH_AUTH_SOCK as string
+                agent = process.env.SSH_AUTH_SOCK!
             }
 
             const authMethodsLeft = ['none']

terminus-terminal/src/api/baseTerminalTab.component.ts

@@ -319,7 +319,7 @@ export class BaseTerminalTabComponent extends BaseTabComponent implements OnInit
     }
 
     async paste (): Promise<void> {
-        let data = this.electron.clipboard.readText() as string
+        let data = this.electron.clipboard.readText()
         if (this.config.store.terminal.bracketedPaste) {
             data = '\x1b[200~' + data + '\x1b[201~'
         }

terminus-terminal/src/colorSchemes.ts

@@ -8,7 +8,7 @@ import { TerminalColorScheme } from './api/interfaces'
 @Injectable()
 export class HyperColorSchemes extends TerminalColorSchemeProvider {
     async getSchemes (): Promise<TerminalColorScheme[]> {
-        const pluginsPath = path.join(process.env.HOME as string, '.hyper_plugins', 'node_modules')
+        const pluginsPath = path.join(process.env.HOME!, '.hyper_plugins', 'node_modules')
         if (!await fs.exists(pluginsPath)) {
             return []
         }

terminus-terminal/src/frontends/xtermFrontend.ts

@@ -153,8 +153,8 @@ export class XTermFrontend extends Frontend {
         host.addEventListener('dragOver', (event: any) => this.dragOver.next(event))
         host.addEventListener('drop', event => this.drop.next(event))
 
-        host.addEventListener('mousedown', event => this.mouseEvent.next(event as MouseEvent))
+        host.addEventListener('mousedown', event => this.mouseEvent.next(event))
-        host.addEventListener('mouseup', event => this.mouseEvent.next(event as MouseEvent))
+        host.addEventListener('mouseup', event => this.mouseEvent.next(event))
         host.addEventListener('mousewheel', event => this.mouseEvent.next(event as MouseEvent))
 
         const ro = new window['ResizeObserver'](() => setTimeout(() => this.resizeHandler()))

terminus-terminal/src/recoveryProvider.ts

@@ -11,8 +11,8 @@ export class RecoveryProvider extends TabRecoveryProvider {
             return {
                 type: TerminalTabComponent,
                 options: {
-                    sessionOptions: recoveryToken['sessionOptions'],
+                    sessionOptions: recoveryToken.sessionOptions,
-                    savedState: recoveryToken['savedState'],
+                    savedState: recoveryToken.savedState,
                 },
             }
         }

terminus-terminal/src/shells/wsl.ts

@@ -72,7 +72,7 @@ export class WSLShellProvider extends ShellProvider {
                 return [{
                     id: 'wsl',
                     name: 'WSL / Bash on Windows',
-                    icon: wslIconMap['Linux'],
+                    icon: wslIconMap.Linux,
                     command: bashPath,
                     env: {
                         TERM: 'xterm-color',

terminus-terminal/src/tabContextMenu.ts

@@ -107,7 +107,7 @@ export class NewTabContextMenu extends TabContextMenuItemProvider {
                 label: 'Duplicate as administrator',
                 click: () => this.zone.run(async () => {
                     this.terminalService.openTabWithOptions({
-                        ...(tab as TerminalTabComponent).sessionOptions,
+                        ...tab.sessionOptions,
                         runAsAdministrator: true,
                     })
                 }),
@@ -150,7 +150,7 @@ export class CopyPasteContextMenu extends TabContextMenuItemProvider {
                     click: (): void => {
                         this.zone.run(() => {
                             setTimeout(() => {
-                                (tab as BaseTerminalTabComponent).frontend.copySelection()
+                                tab.frontend.copySelection()
                                 this.toastr.info('Copied')
                             })
                         })
@@ -159,7 +159,7 @@ export class CopyPasteContextMenu extends TabContextMenuItemProvider {
                 {
                     label: 'Paste',
                     click: (): void => {
-                        this.zone.run(() => (tab as BaseTerminalTabComponent).paste())
+                        this.zone.run(() => tab.paste())
                     },
                 },
             ]