replace ssh2 with russh

tabby-electron/src/services/platform.service.ts

@@ -300,12 +300,12 @@ class ElectronFileUpload extends FileUpload {
     private size: number
     private mode: number
     private file: fs.FileHandle
-    private buffer: Buffer
+    private buffer: Uint8Array
     private powerSaveBlocker = 0
 
     constructor (private filePath: string, private electron: ElectronService) {
         super()
-        this.buffer = Buffer.alloc(256 * 1024)
+        this.buffer = new Uint8Array(256 * 1024)
         this.powerSaveBlocker = electron.powerSaveBlocker.start('prevent-app-suspension')
     }
 
@@ -328,7 +328,7 @@ class ElectronFileUpload extends FileUpload {
         return this.size
     }
 
-    async read (): Promise<Buffer> {
+    async read (): Promise<Uint8Array> {
         const result = await this.file.read(this.buffer, 0, this.buffer.length, null)
         this.increaseProgress(result.bytesRead)
         return this.buffer.slice(0, result.bytesRead)
@@ -370,7 +370,7 @@ class ElectronFileDownload extends FileDownload {
         return this.size
     }
 
-    async write (buffer: Buffer): Promise<void> {
+    async write (buffer: Uint8Array): Promise<void> {
         let pos = 0
         while (pos < buffer.length) {
             const result = await this.file.write(buffer, pos, buffer.length - pos, null)

tabby-electron/src/sftpContextMenu.ts

@@ -49,19 +49,24 @@ export class EditSFTPContextMenu extends SFTPContextMenuItemProvider {
         this.platform.openPath(tempPath)
 
         const events = new Subject<string>()
-        const watcher = fs.watch(tempPath, event => events.next(event))
-        events.pipe(debounceTime(1000), debounce(async event => {
-            if (event === 'rename') {
-                watcher.close()
-            }
-            const upload = await this.platform.startUpload({ multiple: false }, [tempPath])
-            if (!upload.length) {
-                return
-            }
-            await sftp.upload(item.fullPath, upload[0])
-            await sftp.chmod(item.fullPath, item.mode)
-        })).subscribe()
-        watcher.on('close', () => events.complete())
-        sftp.closed$.subscribe(() => watcher.close())
+        fs.chmodSync(tempPath, 0o700)
+
+        // skip the first burst of events
+        setTimeout(() => {
+            const watcher = fs.watch(tempPath, event => events.next(event))
+            events.pipe(debounceTime(1000), debounce(async event => {
+                if (event === 'rename') {
+                    watcher.close()
+                }
+                const upload = await this.platform.startUpload({ multiple: false }, [tempPath])
+                if (!upload.length) {
+                    return
+                }
+                await sftp.upload(item.fullPath, upload[0])
+                await sftp.chmod(item.fullPath, item.mode)
+            })).subscribe()
+            watcher.on('close', () => events.complete())
+            sftp.closed$.subscribe(() => watcher.close())
+        }, 1000)
     }
 }