GuanM/tabby
1
0
Fork 0
mirror of https://github.com/Eugeny/tabby.git synced 2025-06-20 03:20:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Deepclone profile before passing it to the configuration component and fix uncaught error on modal dismiss

Browse Source
This commit is contained in:
highfredo 2021-11-21 13:43:02 +01:00
parent 8ff130ebfd
commit 905e7ffc43
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tabby-settings/src/components/profilesSettingsTab.component.ts
View File

@ -100,18 +100,19 @@ export class ProfilesSettingsTabComponent extends BaseComponent {
if (!provider) { if (!provider) {
throw new Error('Cannot edit a profile without a provider') throw new Error('Cannot edit a profile without a provider')
} }
modal.componentInstance.profile = Object.assign({}, profile) modal.componentInstance.profile = deepClone(profile)
modal.componentInstance.profileProvider = provider modal.componentInstance.profileProvider = provider
const result = await modal.result try {
const result = await modal.result
// Fully replace the config
for (const k in profile) {
// eslint-disable-next-line @typescript-eslint/no-dynamic-delete
delete profile[k]
}
Object.assign(profile, result)
// Fully replace the config profile.type = provider.id
for (const k in profile) { } catch (e) { }
// eslint-disable-next-line @typescript-eslint/no-dynamic-delete
delete profile[k]
}
Object.assign(profile, result)
profile.type = provider.id
} }
async deleteProfile (profile: PartialProfile<Profile>): Promise<void> { async deleteProfile (profile: PartialProfile<Profile>): Promise<void> {