fixed dropping files into the terminal not inserting the path - fixes #10221, fixes #10206

tabby-electron/src/index.ts

@@ -1,6 +1,6 @@
 import { NgModule } from '@angular/core'
 import { PlatformService, LogService, UpdaterService, DockingService, HostAppService, ThemesService, Platform, AppService, ConfigService, WIN_BUILD_FLUENT_BG_SUPPORTED, isWindowsBuild, HostWindowService, HotkeyProvider, ConfigProvider, FileProvider } from 'tabby-core'
-import { TerminalColorSchemeProvider } from 'tabby-terminal'
+import { TerminalColorSchemeProvider, TerminalDecorator } from 'tabby-terminal'
 import { SFTPContextMenuItemProvider, SSHProfileImporter, AutoPrivateKeyLocator } from 'tabby-ssh'
 import { PTYInterface, ShellProvider, UACService } from 'tabby-local'
 import { auditTime } from 'rxjs'
@@ -23,6 +23,7 @@ import { ElectronConfigProvider } from './config'
 import { EditSFTPContextMenu } from './sftpContextMenu'
 import { OpenSSHImporter, PrivateKeyLocator, StaticFileImporter } from './sshImporters'
 import { ElectronPTYInterface } from './pty'
+import { PathDropDecorator } from './pathDrop'
 
 import { CmderShellProvider } from './shells/cmder'
 import { Cygwin32ShellProvider } from './shells/cygwin32'
@@ -73,6 +74,8 @@ import { VSDevToolsProvider } from './shells/vs'
 
         { provide: PTYInterface, useClass: ElectronPTYInterface },
 
+        { provide: TerminalDecorator, useClass: PathDropDecorator, multi: true },
+
         // For WindowsDefaultShellProvider
         PowerShellCoreShellProvider,
         WSLShellProvider,

tabby-electron/src/pathDrop.ts

@@ -0,0 +1,29 @@
+import { Injectable } from '@angular/core'
+import { TerminalDecorator, BaseTerminalTabComponent } from 'tabby-terminal'
+import { webUtils } from 'electron'
+
+/** @hidden */
+@Injectable()
+export class PathDropDecorator extends TerminalDecorator {
+    attach (terminal: BaseTerminalTabComponent<any>): void {
+        setTimeout(() => {
+            this.subscribeUntilDetached(terminal, terminal.frontend?.dragOver$.subscribe(event => {
+                event.preventDefault()
+            }))
+            this.subscribeUntilDetached(terminal, terminal.frontend?.drop$.subscribe((event: DragEvent) => {
+                for (const file of event.dataTransfer!.files as unknown as Iterable<File>) {
+                    this.injectPath(terminal, webUtils.getPathForFile(file))
+                }
+                event.preventDefault()
+            }))
+        })
+    }
+
+    private injectPath (terminal: BaseTerminalTabComponent<any>, path: string) {
+        if (path.includes(' ')) {
+            path = `"${path}"`
+        }
+        path = path.replaceAll('\\', '\\\\')
+        terminal.sendInput(path + ' ')
+    }
+}