GuanM/tabby
1
0
Fork 0
mirror of https://github.com/Eugeny/tabby.git synced 2025-06-09 05:50:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

ref: a9c63b53059c842e31b52d1226aec78c6372fcc3 bad promise rejection handling

Browse Source
This commit is contained in:
Clem 2023-08-25 13:43:43 +02:00
parent 7687972e65
commit 49f9a10372
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tabby-core/src/commands.ts
View File

@ -18,7 +18,7 @@ export class CoreCommandProvider extends CommandProvider {
} }
async activate () { async activate () {
const profile = await this.profilesService.showProfileSelector() const profile = await this.profilesService.showProfileSelector().catch(() => null)
if (profile) { if (profile) {
this.profilesService.launchProfile(profile) this.profilesService.launchProfile(profile)
} }

2
tabby-core/src/index.ts
View File

@ -191,7 +191,7 @@ export default class AppModule { // eslint-disable-line @typescript-eslint/no-ex
this.showSelector(provider) this.showSelector(provider)
} }
if (hotkey === 'command-selector') { if (hotkey === 'command-selector') {
commands.showSelector() commands.showSelector().catch(() => {return})
} }
if (hotkey === 'profile-selector') { if (hotkey === 'profile-selector') {

4
tabby-core/src/services/commands.service.ts
View File

@ -101,7 +101,7 @@ export class CommandService {
context.tab = tab.getFocusedTab() ?? undefined context.tab = tab.getFocusedTab() ?? undefined
} }
const commands = await this.getCommands(context) const commands = await this.getCommands(context)
await this.selector.show( return this.selector.show(
this.translate.instant('Commands'), this.translate.instant('Commands'),
commands.map(c => ({ commands.map(c => ({
name: c.label, name: c.label,
@ -109,6 +109,6 @@ export class CommandService {
description: c.sublabel, description: c.sublabel,
icon: c.icon, icon: c.icon,
})), })),
).catch(() => {return}) ).then(() => {return})
} }
} }

2
tabby-core/src/services/profiles.service.ts
View File

@ -323,7 +323,7 @@ export class ProfilesService {
} }
}) })
await this.selector.show(this.translate.instant('Select profile or enter an address'), options).catch(() => resolve(null)) await this.selector.show(this.translate.instant('Select profile or enter an address'), options).catch(() => reject())
} catch (err) { } catch (err) {
reject(err) reject(err)
} }

2
tabby-core/src/tabContextMenu.ts
View File

@ -262,7 +262,7 @@ export class ProfilesContextMenu extends TabContextMenuItemProvider {
} }
async switchTabProfile (tab: BaseTabComponent) { async switchTabProfile (tab: BaseTabComponent) {
const profile = await this.profilesService.showProfileSelector() const profile = await this.profilesService.showProfileSelector().catch(() => null)
if (!profile) { if (!profile) {
return return
} }