ref(connectable tab) on session destroyed

tabby-serial/src/components/serialTab.component.ts

@@ -83,20 +83,17 @@ export class SerialTabComponent extends ConnectableTerminalTabComponent<SerialPr
             this.write(`\r\n${colors.black.bgWhite(' Serial ')} ${msg}\r\n`)
             this.session?.resize(this.size.columns, this.size.rows)
         })
-        this.attachSessionHandler(this.session!.destroyed$, () => {
+        super.attachSessionHandlers()
+    }
+
+    protected onSessionDestroyed() {
         if (this.frontend) {
             // Session was closed abruptly
             this.write('\r\n' + colors.black.bgWhite(' SERIAL ') + ` session closed\r\n`)
 
-                if (this.profile.behaviorOnSessionEnd === 'reconnect') {
+            super.onSessionDestroyed()
-                    this.reconnect()
-                } else if (this.profile.behaviorOnSessionEnd === 'keep' || this.profile.behaviorOnSessionEnd === 'auto' && !this.isSessionExplicitlyTerminated()) {
-                    this.offerReconnection()
         }
     }
-        })
-        super.attachSessionHandlers()
-    }
 
     async getRecoveryToken (options?: GetRecoveryTokenOptions): Promise<any> {
         return {

tabby-ssh/src/components/sshTab.component.ts

@@ -148,22 +148,14 @@ export class SSHTabComponent extends ConnectableTerminalTabComponent<SSHProfile>
         return session
     }
 
-    protected attachSessionHandlers (): void {
+    protected onSessionDestroyed() {
-        const session = this.session!
-        this.attachSessionHandler(session.destroyed$, () => {
         if (this.frontend) {
             // Session was closed abruptly
             this.write('\r\n' + colors.black.bgWhite(' SSH ') + ` ${this.sshSession?.profile.options.host}: session closed\r\n`)
 
-                if (this.profile.behaviorOnSessionEnd === 'reconnect') {
+            super.onSessionDestroyed()
-                    this.reconnect()
-                } else if (this.profile.behaviorOnSessionEnd === 'keep' || this.profile.behaviorOnSessionEnd === 'auto' && !this.isSessionExplicitlyTerminated()) {
-                    this.offerReconnection()
         }
     }
-        })
-        super.attachSessionHandlers()
-    }
 
     private async initializeSessionMaybeMultiplex (multiplex = true): Promise<void> {
         this.sshSession = await this.setupOneSession(this.injector, this.profile, multiplex)

tabby-telnet/src/components/telnetTab.component.ts

@@ -42,22 +42,14 @@ export class TelnetTabComponent extends ConnectableTerminalTabComponent<TelnetPr
         super.onFrontendReady()
     }
 
-    protected attachSessionHandlers (): void {
+    protected onSessionDestroyed() {
-        const session = this.session!
-        this.attachSessionHandler(session.destroyed$, () => {
         if (this.frontend) {
             // Session was closed abruptly
             this.write('\r\n' + colors.black.bgWhite(' TELNET ') + ` ${this.session?.profile.options.host}: session closed\r\n`)
 
-                if (this.profile.behaviorOnSessionEnd === 'reconnect') {
+            super.onSessionDestroyed()
-                    this.reconnect()
-                } else if (this.profile.behaviorOnSessionEnd === 'keep' || this.profile.behaviorOnSessionEnd === 'auto' && !this.isSessionExplicitlyTerminated()) {
-                    this.offerReconnection()
         }
     }
-        })
-        super.attachSessionHandlers()
-    }
 
     async initializeSession (): Promise<void> {
         await super.initializeSession()

tabby-terminal/src/api/baseTerminalTab.component.ts

@@ -784,7 +784,7 @@ export class BaseTerminalTabComponent<P extends BaseTerminalProfile> extends Bas
         })
 
         this.attachSessionHandler(this.session.destroyed$, () => {
-            this.setSession(null)
+            this.onSessionDestroyed()            
         })
 
         this.attachSessionHandler(this.session.oscProcessor.copyRequested$, content => {
@@ -793,6 +793,13 @@ export class BaseTerminalTabComponent<P extends BaseTerminalProfile> extends Bas
         })
     }
 
+    /**
+     * Method called when session is destroyed. Set the session to null
+     */
+    protected onSessionDestroyed() {
+        this.setSession(null)
+    }
+
     protected detachSessionHandlers (): void {
         this.sessionHandlers.cancelAll()
     }

tabby-terminal/src/api/connectableTerminalTab.component.ts

@@ -33,6 +33,21 @@ export abstract class ConnectableTerminalTabComponent<P extends BaseTerminalProf
         this.reconnectOffered = false
     }
 
+    /**
+    * Method called when session is destroyed. Handle the tab behavior on session end for connectable tab
+    */
+    protected onSessionDestroyed() {
+        super.onSessionDestroyed()
+
+        if (this.frontend) {
+            if (this.profile.behaviorOnSessionEnd === 'reconnect') {
+                this.reconnect()
+            } else if (this.profile.behaviorOnSessionEnd === 'keep' || this.profile.behaviorOnSessionEnd === 'auto' && !this.isSessionExplicitlyTerminated()) {
+                this.offerReconnection()
+            }
+        }
+    }
+    
     /**
     * Offering reconnection to the user if it hasn't been done yet.
     * Set reconnectOffered to true