From 9413c80376144ec3f73fad50d6d65c82c524574e Mon Sep 17 00:00:00 2001 From: Austin Warren Date: Tue, 16 Jul 2019 17:46:45 -0700 Subject: [PATCH 1/3] Ignore pointer-events for svg icons, this fixes some click event propogation issues --- app/src/global.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/src/global.scss b/app/src/global.scss index c6377fd9..df6d4e58 100644 --- a/app/src/global.scss +++ b/app/src/global.scss @@ -16,6 +16,10 @@ body { display: none; } +svg { + pointer-events: none; +} + .form-line { display: flex; border-top: 1px solid rgba(0, 0, 0, 0.2); From b0f8dd40367223de659662bd58a0b3594dbd642b Mon Sep 17 00:00:00 2001 From: Austin Warren Date: Tue, 16 Jul 2019 17:47:11 -0700 Subject: [PATCH 2/3] Remove console warning when attempting to resize without xterm being fully initialized --- terminus-terminal/src/frontends/xtermFrontend.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/terminus-terminal/src/frontends/xtermFrontend.ts b/terminus-terminal/src/frontends/xtermFrontend.ts index a6cb2909..45e6ff17 100644 --- a/terminus-terminal/src/frontends/xtermFrontend.ts +++ b/terminus-terminal/src/frontends/xtermFrontend.ts @@ -85,7 +85,7 @@ export class XTermFrontend extends Frontend { this.resizeHandler = () => { try { - if (getComputedStyle(this.xtermCore.element).getPropertyValue('height') !== 'auto') { + if (this.xtermCore.element && getComputedStyle(this.xtermCore.element).getPropertyValue('height') !== 'auto') { this.fitAddon.fit() } } catch (e) { From 876aee93df1e89a67225356778d1088d0833e503 Mon Sep 17 00:00:00 2001 From: Austin Warren Date: Tue, 16 Jul 2019 17:59:20 -0700 Subject: [PATCH 3/3] reduce scope of svg pointer event css --- app/src/global.scss | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/src/global.scss b/app/src/global.scss index df6d4e58..6f316ea7 100644 --- a/app/src/global.scss +++ b/app/src/global.scss @@ -16,8 +16,10 @@ body { display: none; } -svg { - pointer-events: none; +.btn { + & > svg { + pointer-events: none; + } } .form-line {