don't open second window on app restart when in dock mode (fixes #2449)

app/lib/app.ts

@@ -137,6 +137,13 @@ export class Application {
         }
     }
 
+    handleSecondInstance (argv: string[], cwd: string): void {
+        this.presentAllWindows()
+        for (let window of this.windows) {
+            window.handleSecondInstance(argv, cwd)
+        }
+    }
+
     private setupMenu () {
         let template: Electron.MenuItemConstructorOptions[] = [
             {

app/lib/index.ts

@@ -34,8 +34,7 @@ process.on('uncaughtException' as any, err => {
 })
 
 app.on('second-instance', (_event, argv, cwd) => {
-    application.presentAllWindows()
+    application.handleSecondInstance(argv, cwd)
-    application.send('host:second-instance', parseArgs(argv, cwd), cwd)
 })
 
 const argv = parseArgs(process.argv, process.cwd())

app/lib/window.ts

@@ -5,6 +5,7 @@ import ElectronConfig = require('electron-config')
 import * as os from 'os'
 import * as path from 'path'
 
+import { parseArgs } from './cli'
 import { loadConfig } from './config'
 
 let SetWindowCompositionAttribute: any
@@ -210,6 +211,12 @@ export class Window {
         }
     }
 
+    handleSecondInstance (argv: string[], cwd: string): void {
+        if (!this.configStore.appearance?.dock) {
+            this.send('host:second-instance', parseArgs(argv, cwd), cwd)
+        }
+    }
+
     private setupWindowManagement () {
         this.window.on('show', () => {
             this.visible.next(true)