diff --git a/ui/src/pages/ConsoleLayout.tsx b/ui/src/pages/ConsoleLayout.tsx index d2a5b2b8..47fdc431 100644 --- a/ui/src/pages/ConsoleLayout.tsx +++ b/ui/src/pages/ConsoleLayout.tsx @@ -1,4 +1,4 @@ -import { memo, useCallback, useEffect, useState } from "react"; +import { memo, useEffect, useState } from "react"; import { useTranslation } from "react-i18next"; import { Link, Navigate, Outlet, useLocation, useNavigate } from "react-router-dom"; import { @@ -135,12 +135,12 @@ const SiderMenu = memo(({ onSelect }: { onSelect?: (key: string) => void }) => { }); const [menuSelectedKey, setMenuSelectedKey] = useState(); - const getActiveMenuItem = useCallback(() => { + const getActiveMenuItem = () => { const item = menuItems.find((item) => item!.key === location.pathname) ?? menuItems.find((item) => item!.key !== MENU_KEY_HOME && location.pathname.startsWith(item!.key as string)); return item; - }, [location.pathname, menuItems]); + }; useEffect(() => { const item = getActiveMenuItem(); @@ -149,13 +149,13 @@ const SiderMenu = memo(({ onSelect }: { onSelect?: (key: string) => void }) => { } else { setMenuSelectedKey(undefined); } - }, [location.pathname, getActiveMenuItem]); + }, [location.pathname]); useEffect(() => { if (menuSelectedKey && menuSelectedKey !== getActiveMenuItem()?.key) { navigate(menuSelectedKey); } - }, [menuSelectedKey, navigate, getActiveMenuItem]); + }, [menuSelectedKey]); return ( <> diff --git a/ui/src/pages/accesses/AccessList.tsx b/ui/src/pages/accesses/AccessList.tsx index 27e8b14b..9276b8e6 100644 --- a/ui/src/pages/accesses/AccessList.tsx +++ b/ui/src/pages/accesses/AccessList.tsx @@ -125,7 +125,7 @@ const AccessList = () => { console.error(err); notificationApi.error({ message: t("common.text.request_error"), description: getErrMsg(err) }); }); - }, [fetchAccesses]); + }, []); const { loading } = useRequest( () => { diff --git a/ui/src/pages/settings/Settings.tsx b/ui/src/pages/settings/Settings.tsx index dcb3c6ff..dcd4ef14 100644 --- a/ui/src/pages/settings/Settings.tsx +++ b/ui/src/pages/settings/Settings.tsx @@ -25,7 +25,7 @@ const Settings = () => { } setTabValue(path); - }, [location, navigate]); + }, [location.pathname]); return (