From 599e718003efa4e0d096f9f5acd03f822b0a439a Mon Sep 17 00:00:00 2001
From: Fu Diwei <fudiwei@sina.com>
Date: Tue, 17 Dec 2024 19:19:18 +0800
Subject: [PATCH] feat(ui): props guard

---
 ui/src/components/access/AccessEditForm.tsx  |  2 +-
 ui/src/components/access/AccessEditModal.tsx | 12 ++++++++++--
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/ui/src/components/access/AccessEditForm.tsx b/ui/src/components/access/AccessEditForm.tsx
index 049abd68..1a5b9a07 100644
--- a/ui/src/components/access/AccessEditForm.tsx
+++ b/ui/src/components/access/AccessEditForm.tsx
@@ -178,7 +178,7 @@ const AccessEditForm = forwardRef<AccessEditFormInstance, AccessEditFormProps>((
             rules={[formRule]}
             tooltip={<span dangerouslySetInnerHTML={{ __html: t("access.form.type.tooltip") }}></span>}
           >
-            <AccessTypeSelect disabled={mode === "edit"} placeholder={t("access.form.type.placeholder")} showSearch={!disabled} />
+            <AccessTypeSelect disabled={mode !== "add"} placeholder={t("access.form.type.placeholder")} showSearch={!disabled} />
           </Form.Item>
 
           <Form.Item name="config" hidden />
diff --git a/ui/src/components/access/AccessEditModal.tsx b/ui/src/components/access/AccessEditModal.tsx
index c9baec52..12f9c4bf 100644
--- a/ui/src/components/access/AccessEditModal.tsx
+++ b/ui/src/components/access/AccessEditModal.tsx
@@ -56,9 +56,17 @@ const AccessEditModal = ({ data, loading, mode, trigger, ...props }: AccessEditM
     }
 
     try {
-      if (mode === "add") {
+      if (mode === "add" || mode === "copy") {
+        if (data?.id) {
+          throw "Invalid props: `data`";
+        }
+
         await createAccess(formRef.current!.getFieldsValue() as AccessModel);
-      } else {
+      } else if (mode === "edit") {
+        if (!data?.id) {
+          throw "Invalid props: `data`";
+        }
+
         await updateAccess({ ...data, ...formRef.current!.getFieldsValue() } as AccessModel);
       }