From 6477ef6c447611a310937b42bbbd4507b09a7fb4 Mon Sep 17 00:00:00 2001
From: Senis John <thank243@gmail.com>
Date: Sat, 31 Dec 2022 12:35:55 +0800
Subject: [PATCH] fix: dns memory leak It can be properly working after
 xray-core accept the patch

---
 service/controller/controller.go | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/service/controller/controller.go b/service/controller/controller.go
index 902f295..2c53606 100644
--- a/service/controller/controller.go
+++ b/service/controller/controller.go
@@ -48,7 +48,6 @@ type Controller struct {
 	stm          stats.Manager
 	dispatcher   *mydispatcher.DefaultDispatcher
 	startAt      time.Time
-	dnsFeature   *features.Feature
 }
 
 type periodicTask struct {
@@ -663,15 +662,7 @@ func (c *Controller) addNewDNS(newNodeInfo *api.NodeInfo) error {
 		return err
 	}
 	if feature, ok := obj.(features.Feature); ok {
-		// todo fix memory leak
-		c.Lock()
-		defer c.Unlock()
-		if c.dnsFeature == nil {
-			c.dnsFeature = &feature
-			c.server.AddFeature(feature)
-		} else {
-			*c.dnsFeature = feature
-		}
+		c.server.AddFeature(feature)
 	}
 
 	return nil